3 replies to this topic

[txman]

Alright, I'm teaching myself C++, and I'm stuck on recieving information from files. Here's my code. #include <iostream> #include <fstream> using namespace std; int main() { int x = 0; string out_wanker[500]; string input_wanker; ofstream out_file ("testfile.txt"); cout<<"Give me a file stream!"<<endl; getline(cin, input_wanker, '\n'); out_file<<input_wanker<<" "<<"zarghly"; out_file.close(); ifstream in_file ("testfile.txt"); do { in_file>>out_wanker[x]; cout<<out_wanker[x]<<" "; ++x; }while (out_wanker[x] != "zarghly"); return 0; } Ignore the strange variable names, I'm a strange person. but what I'm trying to do is write a string and read it back in. My hope is that "zarghly" would work as a terminator for the loop. However, thats not how it's working. Sample input. This is a test of how to work with file streams. Sample output. This is a test of how to work with file streams. zarghly (followed by roughly 500 spaces and a termination message) So why isn't my loop terminating as it should?

[txman]

After a nights sleep, I looked at it again and got this as a solution.

as this file hadn't read in a value for out_wanker[x] yet, it didn't read it into the loop as having a value, so the value in it was blank when it checked it to terminate the loop.

ifstream in_file ("testfile.txt");

do
{
in_file>>out_wanker[x];
cout<<out_wanker[x]<<" ";
++x;
}while (out_wanker[x] != "zarghly");

changed that to

ifstream in_file ("testfile.txt");
in_file>>out_wanker[x];
do
{
cout<<out_wanker[x]<<" ";
++x;
in_file>>out_wanker[x];
}while (out_wanker[x] != "aaaaa");

[appleoddity]

I'd have to pull out my C++ books because I don't use this language enough to remember these input/output operations. However, I'm not understanding your second post.

Your second code modification looks "iffy?"

If I am remembering things properly, you are reading a file into a character array one character at a time. You are using x as your pointer in the character array to determine where to store the next character read from the file.

So, heres what I see happening. I am going to reference your first posting because this second posting doesn't look right at all. You are reading a character in, and storing it in the character array out_wanker in the location pointed to by x. You are then incrementing the pointer. Finally, you check the character array against the string "zarghly". However, here's the problem. You are using the pointer x to determine where to start looking for the string "zarghly" at. At this point in the loop the X variable is always pointing to the next position right after the last character read.

Therefore, this is what you are doing. Lets say the out_wanker variable contains "abcd1234", and your pointer (x) is now equal to 8. You then attempt to read from the 8th position, the string "zarghly." All you will get is garbage, because the 8th position on forward has no data in it yet. Instead, you need to start reading from a earlier position in the character array to look for the string zarghly. Because the string "zarghly" is 7 characters long, you will need to use x - 7 as your starting position. The resulting comparison would look like this: out_wanker[x-7] != "zarghly". This way you are looking 7 characters back in the string to see if you have loaded the string "zarghly" in yet.

Now, a technicality persists here. If you haven't read at least 7 characters into the string yet, you will actually point to an out of bounds portion of memory again because x-7 will be less than the beginning of the string. So, you will have to make sure your program reads in 7 characters first before doing any comparisons looking for "zarghly".

My suggestion is that you use the "\n" character to signify when to stop reading. There are certainly better ways to do this, but to use the most basic commands for learning purposes you could just use the comparison (out_wanker[x-1] != '\n'). Your program would then read until the end of the line and stop.

Its late and I'm real tired, so I'm going to stop here, but I hope I cleared up what I see as happening in this program. I could be wrong because I don't remember a couple of things about how the input/output operations work and I'm not sure that you can even do a string comparison on a character array the way that you are doing it. But, I think it is ok. I'll look it up at a better time.

[jpshortstuff]

Would it not be easier to use the eof() function as your termination condition, rather than having a random string?

What would happen if your random string was part of the file? You would terminate prematurely.

Have a look at this link, see if it helps:
http://www.cplusplus...rial/files.html

Hope that helps.